GH-49789: [C++] Use CMAKE_INSTALL_DOCDIR instead of static share/doc/${PROJECT_NAME}#49790
GH-49789: [C++] Use CMAKE_INSTALL_DOCDIR instead of static share/doc/${PROJECT_NAME}#49790kou merged 1 commit intoapache:mainfrom
CMAKE_INSTALL_DOCDIR instead of static share/doc/${PROJECT_NAME}#49790Conversation
…hare/doc/${PROJECT_NAME}`
|
|
kou
added
CI: Extra: Package: Linux
There was a problem hiding this comment.
Pull request overview
This PR updates Arrow C++’s install configuration to use CMake’s standard documentation install directory variable (CMAKE_INSTALL_DOCDIR) instead of a hard-coded share/doc/${PROJECT_NAME}, improving compatibility with downstream packagers and custom install layouts.
Changes:
- Switch
ARROW_DOC_DIRfrom a static path to${CMAKE_INSTALL_DOCDIR}. - Keep existing documentation-related install rules (LICENSE/NOTICE/README) but route them through the standardized docdir variable.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
+1 |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 09cc2cf. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
CMAKE_INSTALL_DOCDIRis the standard variable for install document directory. Packages use this variable to change install document directory.What changes are included in this PR?
Use
CMAKE_INSTALL_DOCDIRinstead of staticshare/doc/${PROJECT_NAME}Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.
CMAKE_INSTALL_DOCDIRinstead of staticshare/doc/${PROJECT_NAME}#49789